nickva commented on code in PR #5858:
URL: https://github.com/apache/couchdb/pull/5858#discussion_r3159201079
##########
src/couch/src/couch_query_servers.erl:
##########
@@ -490,6 +490,8 @@ validate_doc_update(Db, DDoc, EditDoc, DiskDoc, Ctx,
SecObj) ->
case Resp of
ok ->
ok;
+ {[{<<"forbidden">>, Message}, {<<"failures">>, Failures}]} ->
+ throw({forbidden, Message, Failures});
Review Comment:
We're changing the forbidden tuple shape. Make sure to check all the places
which handle `{forbidden, _}` and now they may have to handle the triple-arg
version. I noticed fabric_doc_update needs to handle this
src/fabric/src/fabric_doc_update.erl
We should also call out and see if this will affect online cluster upgrades
(new worker nodes throwing it and old coordinator nodes getting function clause
errors). It maybe be fine, just needs an extra careful look at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
