jcoglan commented on code in PR #5858:
URL: https://github.com/apache/couchdb/pull/5858#discussion_r3201808030
##########
src/mango/src/mango_native_proc.erl:
##########
@@ -112,14 +112,30 @@ handle_call({prompt, [<<"ddoc">>, DDocId,
[<<"validate_doc_update">>], Args]}, _
Msg = [<<"validate_doc_update">>, DDocId],
{stop, {invalid_call, Msg}, {invalid_call, Msg}, St};
Selector ->
- [NewDoc, OldDoc, _Ctx, _SecObj] = Args,
- Struct = {[{<<"newDoc">>, NewDoc}, {<<"oldDoc">>, OldDoc}]},
- Reply =
- case mango_selector:match(Selector, Struct) of
- true -> true;
- _ -> {[{<<"forbidden">>, <<"document is not valid">>}]}
- end,
- {reply, Reply, St}
+ case mango_selector:has_allowed_fields(Selector, [<<"newDoc">>,
<<"oldDoc">>]) of
+ false ->
+ Msg =
+ <<"'validate_doc_update' may only contain 'newDoc' and
'oldDoc' as top-level fields">>,
+ {stop, {invalid_call, Msg}, {invalid_call, Msg}, St};
+ true ->
+ [NewDoc, OldDoc, _Ctx, _SecObj] = Args,
+ Struct =
+ case OldDoc of
+ null -> {[{<<"newDoc">>, NewDoc}]};
Review Comment:
We changed this because it created a confusing UI where you'd have to say
`"oldDoc": null` instead of `"oldDoc": { "$exists": false }` which would be
more intuitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
