fantiq opened a new pull request, #15594:
URL: https://github.com/apache/dubbo/pull/15594

   ## What is the purpose of the change?
   
   resolve #15271 #15003 , this issues are related to the config option 
`registry.check`. 
   
   When `registry.check=true` (default value is `true`) is set, the connection 
status will be checked when creating the registry client. if the check fails, 
an exception will be thrown. 
   when `registry.check=false` is set, no check is performed and no exception 
is ever thrown.
   
   The reason for NEP is caused by setting the option `registry.check` to 
`false` and throwning an exception.
   so here when `registry.check=false` no exception should be thrown. that is, 
the connection status should not be checked.
   
   Currently, in the nacos client, the option `nacos.check` is used to 
determine whether to check the connection status or not.
   the zookeeper client does not yet support not checking the connection status.
   
   This PR add an new option `zookeeper.check`, it is similar to option 
`nacos.check`.
   
   When creating a registry client, it will first be created using the default 
behavior. if an exception is thrown and `registry.check=false`, 
   it will try to create the registry client again by turning on the option 
(`nacos.check=false` or `zookeeper.check=false`) to not check the connection 
status.
   
   
   ## Checklist
   - [x] Make sure there is a 
[GitHub_issue](https://github.com/apache/dubbo/issues) field for the change.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test to verify your logic correction. If the new 
feature or significant change is committed, please remember to add sample in 
[dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [x] Make sure gitHub actions can pass. [Why the workflow is failing and 
how to fix it?](../CONTRIBUTING.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to