fantiq commented on code in PR #15594:
URL: https://github.com/apache/dubbo/pull/15594#discussion_r2246924143
##########
dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosConnectionManager.java:
##########
@@ -116,7 +120,7 @@ public synchronized void shutdownAll() {
* @return {@link NamingService}
*/
protected NamingService createNamingService() {
- Properties nacosProperties = buildNacosProperties(this.connectionURL);
+ // Properties nacosProperties =
buildNacosProperties(this.connectionURL);
Review Comment:
> why not delete it directly?
i missed it there, i'll remove it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
