zrlw opened a new pull request, #15602:
URL: https://github.com/apache/dubbo/pull/15602

   ## What is the purpose of the change?
   Since the non-static final fields initialized at declaration will not be 
initialized during it's owner object construction, NullPointerException (NPE)‌ 
will be thrown if using them during the construction just like 
https://github.com/apache/dubbo/issues/14848
   These fields should be changed to non-final and be initialized at it's owner 
construction  to prevent ‌NPE.
   
   By the way, this PR only serves as a ‌**mitigation measure‌**. The ‌best 
solution‌ is to ‌refactor the code‌ by:
   -‌ Splitting the Constructor‌ – Isolating initialization logic from business 
logic.
   -‌ Extracting Non-Construction Logic‌ – Moving unrelated processing to 
separate methods.
   
   ## Checklist
   - [x] Make sure there is a 
[GitHub_issue](https://github.com/apache/dubbo/issues) field for the change.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test to verify your logic correction. If the new 
feature or significant change is committed, please remember to add sample in 
[dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [x] Make sure gitHub actions can pass. [Why the workflow is failing and 
how to fix it?](../CONTRIBUTING.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to