Copilot commented on code in PR #15602:
URL: https://github.com/apache/dubbo/pull/15602#discussion_r2246831679
##########
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/exchange/support/header/AbstractTimerTask.java:
##########
@@ -42,7 +42,7 @@ public abstract class AbstractTimerTask implements TimerTask {
this.channelProvider = channelProvider;
this.hashedWheelTimer = hashedWheelTimer;
this.tick = tick;
- start();
+ // do not start here because inheritor should set additional timeout
parameters before doing task.
Review Comment:
The word 'inheritor' should be 'subclass' or 'subclasses' for better clarity
and standard terminology.
```suggestion
// do not start here because subclass should set additional timeout
parameters before doing task.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
