robocanic commented on code in PR #1340: URL: https://github.com/apache/dubbo-admin/pull/1340#discussion_r2448645677
########## app/dubbo-admin/dubbo-admin.yaml: ########## @@ -39,17 +39,55 @@ console: store: type: memory discovery: - - type: nacos - id: nacos-44.33 - address: - registry: nacos://47.76.94.134:8848?username=nacos&password=nacos - configCenter: nacos://47.76.94.134:8848?username=nacos&password=nacos - metadataReport: nacos://47.76.94.134:8848?username=nacos&password=nacos - - type: istio +# - type: nacos +# id: nacos-44.33 +# address: +# registry: nacos://47.76.94.134:8848?username=nacos&password=nacos +# configCenter: nacos://47.76.94.134:8848?username=nacos&password=nacos +# metadataReport: nacos://47.76.94.134:8848?username=nacos&password=nacos + # mock discovery is only for development + - type: mock engine: name: k8s1.28.6 type: kubernetes properties: - apiServerAddress: https://192.168.1.1:6443 - kubeConfig: /etc/kubernetes/admin.conf + # [Kubernetes] Path to kubernetes config file, if not set, will use in cluster config + kubeConfigPath: /root/.kube/config + # [Kubernetes] Watch pods with specified labels, if not set, will watch all pods + # podWatchSelector: org.apache.dubbo/dubbo-apps=true + # [Kubernetes] Identify which Dubbo app the pod belongs to, if not set, [type = ByIP] will be used + # 1. ByLabels: Use the label value corresponding to the labelKey as the dubbo app name + # e.g. + # type: ByLabel + # labelKey: org.apache.dubbo/dubbo-app-name + # 2. ByAnnotation: Use the annotation value corresponding to the annotationKey as the dubbo app name + # e.g. + # type: ByAnnotation + # annotationKey: org.apache.dubbo/dubbo-app-name + # 3. ByIP(default): Use pod's IP to find if there is a same ip of an instance and use the instance's app name as the identifier, + # if there is no such association, the pod will not be seen as a pod of dubbo application. + # e.g. + # type: ByIP +# dubboAppIdentifier: +# type: ByLabel +# labelKey: org.apache.dubbo/dubbo-app-name + # [Kubernetes] Strategy of choosing the main container, if not set, [type = ByIndex] and [index = 0] will be used + # 1. ByLast: choose the last container as the main container + # e.g. + # type: ByLast + # 2. ByIndex(default): choose the container at the specified index location as the main container + # e.g. + # type: ByIndex + # index: 0 + # 3. ByName: choose the container with the specified name + # e.g. + # type: ByName + # name: main + # 4. chooseByAnnotation: choose the container with the annotation key, specified annotation value will be used as the container name Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
