AlexStocks commented on code in PR #1340:
URL: https://github.com/apache/dubbo-admin/pull/1340#discussion_r2483070983
##########
pkg/core/resource/apis/mesh/v1alpha1/affinityroute_types.go:
##########
@@ -106,6 +108,15 @@ func (r *AffinityRouteResource) DeepCopyObject()
k8sruntime.Object {
return out
}
+func (r *AffinityRouteResource) String() string {
+ jsonStr, err := json.Marshal(r)
+ if err != nil {
+ logger.Errorf("failed to encode AffinityRouteResource: %s to
json, err: %s", r.ResourceKey(), err)
Review Comment:
error 输出一般这样写： err: %w，其他地方也改下吧
##########
api/mesh/v1alpha1/rpc_instance_metadata.proto:
##########
@@ -6,7 +6,7 @@ option go_package =
"github.com/apache/dubbo-admin/api/mesh/v1alpha1";
import "api/mesh/options.proto";
-message RPCInstanceMetaData {
+message RpcInstanceMetadata {
Review Comment:
<img width="1550" height="522" alt="Image"
src="https://github.com/user-attachments/assets/3b220bde-41bd-47d4-a209-b5c054469b71";
/>
##########
pkg/core/resource/apis/mesh/v1alpha1/application_types.go:
##########
@@ -106,6 +108,15 @@ func (r *ApplicationResource) DeepCopyObject()
k8sruntime.Object {
return out
}
+func (r *ApplicationResource) String() string {
+ jsonStr, err := json.Marshal(r)
+ if err != nil {
+ logger.Errorf("failed to encode ApplicationResource: %s to
json, err: %s", r.ResourceKey(), err)
Review Comment:
error 输出一般这样写： err: %w
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
