Alanxtl commented on code in PR #3370: URL: https://github.com/apache/dubbo-go/pull/3370#discussion_r3360087883
########## metadata/info/metadata_info.go: ########## Review Comment: `metadata/info/metadata_info.go:50-59` 的 `IncludeKeys` 里包含 `environment`，PR 新逻辑会把它纳入 revision；但 consumer 侧 `registry/servicediscovery/service_instances_changed_listener_impl.go:181-200` 明确把 environment 当 instance-level routing metadata，用 instance 当前值覆盖，不该依赖 revision cache。这会让 revision 因实例级字段变化而变化，和现有设计注释冲突，最好把 instance-level 字段排除或明确改设计。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
