Alanxtl commented on code in PR #3370:
URL: https://github.com/apache/dubbo-go/pull/3370#discussion_r3362634402
##########
metadata/info/metadata_info.go:
##########
@@ -55,9 +55,15 @@ var IncludeKeys = gxset.NewSet(
constant.VersionKey,
constant.WarmupKey,
constant.WeightKey,
- constant.EnvironmentKey,
constant.ReleaseKey)
+// EnvironmentKey is intentionally excluded from IncludeKeys because
+// environment is instance-level routing metadata, not service-level.
+// Consumer code in service_instances_changed_listener_impl.go overrides
+// environment from the current instance metadata, so including it in
+// the revision would cause unnecessary revision changes between
+// instances with different environment tags.
+
Review Comment:
这种一看就是ai生成的comment不用加
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
