Qiao-yq commented on code in PR #3370:
URL: https://github.com/apache/dubbo-go/pull/3370#discussion_r3385115924


##########
metadata/info/metadata_info.go:
##########
@@ -174,6 +176,15 @@ func (info *MetadataInfo) ReplaceExportedServices(urls 
[]*common.URL) {
        }
 }
 
+// CalAndGetRevision calculates and updates the revision for this MetadataInfo.
+// The revision is derived from the canonical ServiceInfo representation,
+// ensuring strong binding between revision and serialized metadata content.
+// Aligned with Java dubbo MetadataInfo.calAndGetRevision().
+func (info *MetadataInfo) CalAndGetRevision() string {
+       info.Revision = CalRevision(info.App, info.Services)

Review Comment:
   我确认了一下,这个方法只有测试函数调用,两者都不必要,可以删除方法和对应测试



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to