Copilot commented on code in PR #964:
URL: https://github.com/apache/dubbo-go-pixiu/pull/964#discussion_r3409096751
##########
Makefile:
##########
@@ -68,6 +68,11 @@ test:
sh before_ut.sh
go test ./pkg/... -gcflags=-l -coverprofile=coverage.txt
-covermode=atomic
+lint:check-lint
+ @golangci-lint run
+check-lint:
+ @type golangci-lint >/dev/null 2>&1 || echo "golangci-lint is not
installed, please install it first by run 'go install
github.com/golangci/golangci-lint/v2/cmd/[email protected]'"
Review Comment:
`check-lint` only prints an install hint when `golangci-lint` is missing,
but still exits successfully. That means `make lint` will continue and then
fail with a less helpful `golangci-lint: not found` error. Make the check fail
(non-zero) after printing the hint so the target stops early with a clear
message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
