AlexStocks commented on code in PR #964:
URL: https://github.com/apache/dubbo-go-pixiu/pull/964#discussion_r3410662025
##########
.golangci.yaml:
##########
@@ -49,9 +49,6 @@ linters:
- linters:
- gosec
text: weak cryptographic primitive
- - linters:
- - staticcheck
- text: 'SA1019:'
- linters:
Review Comment:
[P1] 这里直接移除全局 `SA1019` 排除后，CI 会把仓库里已有的 deprecated-symbol 全部重新报出来。当前 Golang
Lint 日志已经有 30 个 SA1019，并且 `issues.new: true` 没有兜住，因为 action 的浅克隆里 revgrep 报
`fatal: bad revision 'HEAD~'`，导致 diff 过滤失效。请先修 CI 的
fetch-depth/new-from-rev，或只在明确范围内启用 SA1019；否则这个 PR 会持续让 lint job 阻断。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
