Copilot commented on code in PR #135:
URL: https://github.com/apache/dubbo-getty/pull/135#discussion_r3599964267
##########
Makefile:
##########
@@ -36,7 +36,7 @@ test: clean
fmt: install-imports-formatter
# replace interface{} with any
- go run
golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest
-category=efaceany -fix -test ./...
+ go run
golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -any
-fix -test ./...
Review Comment:
`modernize@latest` keeps the fmt target coupled to upstream CLI changes
(this is what caused the recent CI break). To make CI more stable, consider
pinning `modernize` to a known-good `golang.org/x/tools` version (and
optionally centralize it in a Makefile variable).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
