AlexStocks commented on code in PR #135:
URL: https://github.com/apache/dubbo-getty/pull/135#discussion_r3600506989
##########
.github/workflows/github-actions.yml:
##########
@@ -28,7 +28,7 @@ jobs:
# If you want to matrix build , you can append the following list.
matrix:
go_version:
- - '1.23'
+ - '1.24'
Review Comment:
明确一下，正确的最小改法就是当前 Head `c50b47ea`：
- `.github/workflows/github-actions.yml` 继续使用 Go 1.23，不提升唯一的代码测试矩阵；
- `Makefile` 中的 `modernize` 使用公开入口并固定 `v0.38.0`，只在该命令前设置
`GOTOOLCHAIN=go1.24.0`。
我已在 WSL 验证 `GOTOOLCHAIN=go1.23.12 go vet ./...`，以及 `GOTOOLCHAIN=go1.24.0 go
run golang.org/x/tools/go/analysis/passes/modernize/cmd/[email protected] -any
-diff -test ./...`，两条命令均通过，工作区没有产生改动。这个 P1 在代码层面已经修复，不需要再调整实现；当前新 Head 尚无
checks，接下来只需批准或触发 Actions，并确认检查通过。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
