AlexStocks commented on code in PR #3507:
URL: https://github.com/apache/dubbo-go/pull/3507#discussion_r3642581364
##########
protocol/triple/triple.go:
##########
@@ -151,7 +151,7 @@ func (tp *TripleProtocol) Refer(url *common.URL)
base.Invoker {
// Use NewTripleInvoker for:
// 1. New protoc-gen-go-triple stub code (has ClientInfoKey)
// 2. Non-IDL mode (IDLMode == NONIDL)
- // 3. Generic call (generic=true/gson/protobuf/protobuf-json)
+ // 3. Generic call (generic=true/gson/protobuf-json/bean, or legacy
protobuf)
Review Comment:
[P2] 这里需要修正文案，但不要把 `protobuf` normalize 为
`protobuf-json`。两者的历史参数语义不同：`protobuf` 在 Triple 中是选择 `$invoke` invoker 的 legacy
routing marker，provider generic filter 仍按 Hessian/Map 处理；`protobuf-json` 则要求
JSON string 或 `proto.Message`。本轮 Base/Head overlay 用 Hessian string、map 和带
class 的 POJO map 均通过，说明当前 PR 保持了旧行为。此前把两者直接映射的对照会稳定报 `the type of obj(=string)
should be proto.Message`。建议只把注释改成“legacy Triple routing marker”，不要采用 normalize
方案；真正迁移需要独立的 consumer/provider 兼容设计。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
