Snow-kal commented on code in PR #3507:
URL: https://github.com/apache/dubbo-go/pull/3507#discussion_r3680613372
##########
protocol/triple/triple.go:
##########
@@ -151,7 +151,7 @@ func (tp *TripleProtocol) Refer(url *common.URL)
base.Invoker {
// Use NewTripleInvoker for:
// 1. New protoc-gen-go-triple stub code (has ClientInfoKey)
// 2. Non-IDL mode (IDLMode == NONIDL)
- // 3. Generic call (generic=true/gson/protobuf/protobuf-json)
+ // 3. Generic call (generic=true/gson/protobuf-json/bean, or the legacy
protobuf routing marker)
Review Comment:
protobuf 这里仅作为历史兼容的 routing marker 保留，用来让旧 generic=protobuf 配置仍走支持 $invoke 的
NewTripleInvoker。
直接删除会破坏老配置；改成 protobuf-json 又会改变 provider 侧参数语义,所以保留兼容一下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
