Tsukikage7 opened a new pull request, #3763:
URL: https://github.com/apache/dubbo-go/pull/3763

   ### Description
   Refs #3721. Supplemental acceptance coverage for the regression tests 
contributed by AsperforMias in #3744, which was merged into `develop`.
   
   The original adapters already support dynamic levels. This PR completes the 
output assertions that were missing from the merged tests: context debug and 
formatted lower-level suppression at warn, formatted context correlation, and 
untraced context behavior at every tested level.
   
   On the same real adapter instance, ordered table-driven tests move `info → 
debug → warn`. At each threshold, they exercise all 18 variants: 
debug/info/warn × ordinary, ordinary formatted, traced context, traced context 
formatted, untraced context, and untraced context formatted. This gives 54 
cases per adapter and 108 cases across Zap and Logrus. Each suppressed call 
must produce an empty capture; every emitted traced-context call checks the 
exact deterministic trace ID, span ID, and trace flags. Emitted calls without a 
valid span must omit correlation fields.
   
   Only the two adapter test files change. The existing factory coverage, 
invalid-level threshold preservation, and facade tests with global-state 
restoration remain in place. No production code changes or external 
Collector/backend are needed.
   
   This is a supplement to the original contributor's work, not a replacement 
implementation. It references #3721 without requesting automatic closure. The 
contribution targets `develop`, matching #3744 and the repository PR template; 
inclusion in the final 3.3.3 release ref remains a separate acceptance step.
   
   ### Validation
   
   Verified locally on Go 1.25.0 (darwin/arm64), matching the repository's 
`go.mod` and CI toolchain selection, on top of 
`develop@5d892b0a7fd4fb5e6679112a18eccbf8a6eabab2`:
   
   ```text
   go test -mod=readonly -count=1 -v ./logger/ ./logger/core/zap/ 
./logger/core/logrus/
   go test -mod=readonly -count=1 -race ./logger/ ./logger/core/zap/ 
./logger/core/logrus/
   make check-fmt
   git diff --check upstream/develop...HEAD
   ```
   
   All three relevant packages pass both ordinary and race tests; all 108 
matrix cases pass. The changed files were formatted with Go 1.25.0 `gofmt`. 
Full-repository `make fmt` and `make test` were not run locally; the checks 
above cover the logger scope of this supplemental change.
   
   ### Checklist
   - [x] I confirm the target branch is `develop`
   - [ ] I have run `make fmt` to format my code (used `gofmt` and `make 
check-fmt`)
   - [ ] I have run `make test` to run local tests (ran the three relevant 
logger packages, including race checks)
   - [x] I have added tests that prove my fix is effective or that my feature 
works
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to