Tsukikage7 commented on PR #3763: URL: https://github.com/apache/dubbo-go/pull/3763#issuecomment-6207703628
Thanks @AsperforMias for independently checking the acceptance cases. I re-reviewed `39c456d99746a0040c01dc9bf9a620a83be3fb6b` against the current `develop` base and marked this PR ready for review. The two-file change covers the info → debug → warn transition on the same real adapter, ordinary/context-aware/formatted output, exact deterministic trace fields, absence of fields without a valid span, and invalid-level behavior. I found no unresolved review threads or merge conflict. Fresh verification from a clean archive of the PR head, Go 1.25.0 / darwin/arm64: ```sh go test -mod=readonly -count=1 ./logger/ ./logger/core/zap/ ./logger/core/logrus/ go test -mod=readonly -count=1 -race ./logger/ ./logger/core/zap/ ./logger/core/logrus/ ``` Both passed; the JSON test results confirm all 108 acceptance cases passed. Targeted gofmt and diff whitespace checks also passed. All 11 reported checks on this head are green, including Format, Lint, Unit Test and Integration Test. #3721 remains open pending review and merge of this supplement to #3744. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
