Hrishikeshmundhe opened a new pull request, #16566:
URL: https://github.com/apache/dubbo/pull/16566

   ## What is the purpose of the change?
   
   Fixes 
[[apache/dubbo#16561](https://github.com/apache/dubbo/issues/16561)](https://github.com/apache/dubbo/issues/16561).
   
   Triple REST path normalization incorrectly treated `?` as a query-string 
delimiter even when processing registered mapping and filter patterns.
   
   This prevented question-mark wildcards (for example, `/pages/t?st.html`) and 
regular expressions containing optional quantifiers (for example, 
`/orders/{id:\\d+(?:-\\d+)?}`) from working correctly.
   
   This change introduces pattern-specific path normalization that preserves 
`?` in registered patterns while retaining the existing behavior of stripping 
query strings from incoming request URIs. Fragment markers (`#`) continue to be 
stripped.
   
   Regression tests cover wildcard matching, optional regex quantifiers, filter 
patterns, and path normalization.
   
   **Testing**: 219 tests passed, 0 failures, 0 errors, 0 skipped.
   
   ## Checklist
   
   - [x] Make sure there is a 
[[GitHub_issue](https://github.com/apache/dubbo/issues)](https://github.com/apache/dubbo/issues)
 field for the change.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test to verify your logic correction. If the new 
feature or significant change is committed, please remember to add sample in 
[[dubbo 
samples](https://github.com/apache/dubbo-samples)](https://github.com/apache/dubbo-samples)
 project.
   - [ ] Make sure GitHub Actions can pass. [[Why the workflow is failing and 
how to fix it?](https://chatgpt.com/CONTRIBUTING.md)](../CONTRIBUTING.md)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

  • [PR] Fix question mark ha... Hrishikeshmundhe (via GitHub) via notifications

Reply via email to