AsperforMias opened a new pull request, #3799:
URL: https://github.com/apache/dubbo-go/pull/3799

   ### Description
   Fixes #3793
   
   Task E from the #3792 audit: publish replayable version evidence and bounded 
regression for condition/tag router B3/B4. **Tests, fixtures, and docs only** — 
no product router/SDK changes, no `go.mod` / `go.sum`, no backport.
   
   **What this adds**
   - Local B3 coverage for `configVersion < 3.1`: all four `enabled`/`force` 
combinations plus omitted fields, asserting selected providers (or empty), with 
a structured `v3.1` control.
   - Reuses #3772 for B4 application-name lifecycle; extends config-center RPC 
harness with per-run isolation and create-after-subscribe checks for condition 
and tag.
   - Opt-in `TestAdminTagZooKeeperDefaultRPC` that keeps the known Admin vs Go 
default ZK path mismatch as a visible product FAIL (Admin #1625 / #1629 / 
#1523), separate from configured Pass.
   - `cluster/router/condition/testdata/admin/VERSION-EVIDENCE.md`: formal-tag 
matrix, fixture provenance, configured vs default results, commands and exit 
codes.
   
   **Design choices**
   1. *Do not re-implement #3772/#3773.* Existing coverage is run and cited; 
new tests only fill gaps called out in #3793.
   2. *Parser fixtures vs Admin captures.* Inline v3.0/v3.1 YAML in the Go test 
are labeled parser fixtures. Committed Admin YAML payloads are unchanged aside 
from license comments; RPC runs retarget names/addresses as test inputs.
   3. *Configured Pass ≠ default interoperability.* Configured Nacos/ZK rows 
use explicit group or root/namespace. Default ZK tag failure is retained, not 
Skip'd when the endpoint env is set.
   4. *Upgrade note.* v3.3.2 covers B4 only; B3 still needs a later formal 
release with the develop fix. Backport scope is left to maintainers.
   
   **Verification (local, 2026-11-06)**
   - Base `415f5d17` (`develop`).
   - `go test ./cluster/router/condition/... ./cluster/router/tag/... -count=1` 
→ 0
   - `go test -race ./cluster/router/condition ./cluster/router/tag -count=1` → 0
   - Condition + tag config-center RPC against compose Nacos 2.5.2 / ZK 3.9.4 → 0
   - Default ZK tag diagnostic → 1 (expected product FAIL)
   - `make fmt` / `make test` → 0
   
   ### Checklist
   - [x] I confirm the target branch is `develop`
   - [x] I have run `make fmt` to format my code
   - [x] I have run `make test` to run local tests
   - [x] I have added tests that prove my fix is effective or that my feature 
works


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to