AlexStocks commented on code in PR #3799:
URL: https://github.com/apache/dubbo-go/pull/3799#discussion_r4521779521
##########
cluster/router/tag/admin_integration_test.go:
##########
@@ -140,10 +140,55 @@ func TestAdminTagConfigCenterRPC(t *testing.T) {
require.Eventually(t, func() bool { _, exists :=
p.routerConfigs.Load(key); return !exists }, 15*time.Second,
50*time.Millisecond)
check("gray", false, invokers...)
check("", false, invokers...)
+ publish(fixture("enabled"))
+ check("gray", false, invokers[0]) // Created after the
listener was registered.
})
}
}
+// This opt-in diagnostic expects default ZooKeeper settings to read Admin's
+// location. A failure is kept visible separately from the configured test.
+func TestAdminTagZooKeeperDefaultRPC(t *testing.T) {
Review Comment:
[P2] 新增的 TestAdminTagZooKeeperDefaultRPC 不会在 CI 中执行
触发条件:该文件首行为 `//go:build adminintegration`;对 `.github/` 与 `Makefile` 全文检索
`adminintegration` 无任何命中,即没有任何 CI job 或 make 目标传入该构建标签。
实际影响:这条用例在任何 CI 中都不会被编译,只能靠本地手工加 `-tags adminintegration` 并设置
`DUBBO_TAG_ZOOKEEPER` 才能运行,因此无法为 Admin 默认 ZooKeeper 路径提供回归保护;PR
描述中"已添加证明生效的测试"对该用例不成立。
证据:cluster/router/tag/admin_integration_test.go 第 1 行 build tag;`.github/` 与
`Makefile` 检索结果为空。
修复方向:把该用例移到无 build tag 的测试文件中并在函数内用 `t.Skip` 控制(同目录的
admin_compatibility_test.go 就是这种写法),或在 CI 增加带 `-tags adminintegration` 的 job。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]