chaoyoung commented on PR #16585: URL: https://github.com/apache/dubbo/pull/16585#issuecomment-6761636019
### WebSocket regression fixed and locally revalidated Commit 2abcce2 fixes the first CI run's real WebSocket regression: the pending-input wrapper hid FinalFragment metadata. The marker-preserving adapter now lives in the WebSocket listener, so the generic HTTP/gRPC listener does not acquire a mandatory dependency on the optional WebSocket module. Original-message close-once ownership is unchanged. Before pushing this update, I ran: - Two new fragment regressions: original PR fails; corrected implementation passes. Added a close-IOException/exact-once cleanup test. - Full Triple package: 483 tests, zero failures/errors, two pre-existing @Disabled WriteQueueTest cases. - Real Netty and Tomcat WebSocket sample: original PR 16/16 failures; corrected implementation 16/16 passing on both JDK 21 and JDK 25. These local runs use no registry, checkout core classes, and released 3.3.6 Spring Boot bootstrap dependencies. They do not reproduce the exact CI Nacos/dependency matrix. - Local JaCoCo covers all added executable lines in GenericHttp2ServerTransportListener and the WebSocket adapter; three short-circuit condition lines remain partially branch-covered. This is not a claim of full PR branch coverage. - Spotless, git diff whitespace check, and independent review pass. No snapshot artifacts were installed into the local Maven repository. Updated GitHub CI remains pending; the previous failed run must not be treated as passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
