chaoyoung commented on PR #16585:
URL: https://github.com/apache/dubbo/pull/16585#issuecomment-6916532079

   Follow-up in f6432631cf1e7135d67604952ecbd91b7e64ed7f addresses the review 
comments after local validation:
   
   - Finalize rejected DATA in a finally block around error handling.
   - Detach pending inputs under the lifecycle lock, then close outside it. 
Keep the existing deferral while DATA callbacks are handing input to the 
decoder. Isolate per-input close exceptions so one unchecked failure cannot 
abandon the remaining snapshot.
   - Use the FinalFragment import in the WebSocket adapter.
   - Retain handoff-before-callback ownership: a new pre-consumption 
callback-failure control already passes on the previous code through existing 
error cleanup. Moving removal after callback success would let transport 
cleanup close decoder-owned buffered input during cancellation. The inline 
reply explains the boundary.
   
   Before pushing, the rejection-finalization and lock-held-close tests 
reproduced their failures; the snapshot close-failure test also failed before 
the extra fix. Final validation on OpenJDK 25:
   
   ```sh
   mvn -q -pl dubbo-rpc/dubbo-rpc-triple -am -Pjacoco \
     
'-Dtest=org.apache.dubbo.rpc.protocol.tri.**.*Test,GenericHttp2ServerTransportListenerTest'
 \
     -Dsurefire.failIfNoSpecifiedTests=false -Dspotless.action=apply test 
jacoco:report
   mvn -q -pl dubbo-rpc/dubbo-rpc-triple -am -DskipTests 
-Dspotless.action=check validate
   git diff --check
   ```
   
   Triple reports 486 tests, 0 failures, 0 errors, 2 existing disabled 
WriteQueueTest methods; the ownership test class has 18 passing tests. 
Formatting and whitespace checks passed. Independent review found no remaining 
blocking issue.
   
   The real dubbo-samples Triple WebSocket Netty/Tomcat clients also pass 16 
tests each on JDK 21 and JDK 25, rerun after the final fix. These runs use the 
checkout core classes with released 3.3.6 Spring Boot bootstrap dependencies 
and no registry; they do not replace the upstream Nacos/dependency matrix or 
whole-repository CI. The previous head CI was green; new-head CI results are 
separate from these local checks.
   
   All four review threads have replies and remain available for reviewer 
confirmation. Could a maintainer review this update when available? AI 
assistance was used for the follow-up and validation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to