AsperforMias commented on code in PR #3799:
URL: https://github.com/apache/dubbo-go/pull/3799#discussion_r4522484266


##########
cluster/router/tag/admin_integration_test.go:
##########
@@ -140,10 +140,55 @@ func TestAdminTagConfigCenterRPC(t *testing.T) {
                        require.Eventually(t, func() bool { _, exists := 
p.routerConfigs.Load(key); return !exists }, 15*time.Second, 
50*time.Millisecond)
                        check("gray", false, invokers...)
                        check("", false, invokers...)
+                       publish(fixture("enabled"))
+                       check("gray", false, invokers[0]) // Created after the 
listener was registered.
                })
        }
 }
 
+// This opt-in diagnostic expects default ZooKeeper settings to read Admin's
+// location. A failure is kept visible separately from the configured test.
+func TestAdminTagZooKeeperDefaultRPC(t *testing.T) {

Review Comment:
   感谢指出。已去掉 `adminintegration` 构建标签,改成与 
`condition/admin_config_center_rpc_test.go` 一致的写法:文件始终参与编译,未设置 
`DUBBO_TAG_NACOS` / `DUBBO_TAG_ZOOKEEPER` 时用 `t.Skip` 跳过。需要说明的是,CI 目前没有 Nacos / 
ZooKeeper,所以这些用例在 CI 里只保证能编译,仍然会跳过;真正执行需要按 PR 描述用 `testdata/admin/compose.yaml` 
在本地起服务。如果希望在 CI 里实际执行,我可以另开 PR 加一个带服务容器的 job。
   
   另外,apache/dubbo-admin#1553 合入后,Admin 在 ZooKeeper 上改为写 
`/dubbo/config/dubbo/<key>`,与 dubbo-go 的默认读取路径一致。因此标签路由和条件路由的 ZooKeeper 
用例都已改用新路径,`TestAdminTagZooKeeperDefaultRPC` 也改为必须通过的用例,PR 描述里相应的结论一并修正。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to