zouyx commented on a change in pull request #722:
URL: https://github.com/apache/dubbo-go/pull/722#discussion_r479721966
##########
File path: protocol/protocolwrapper/protocol_filter_wrapper.go
##########
@@ -68,21 +68,16 @@ func (pfw *ProtocolFilterWrapper) Destroy() {
}
func buildInvokerChain(invoker protocol.Invoker, key string) protocol.Invoker {
- filtName := invoker.GetUrl().GetParam(key, "")
- if filtName == "" {
Review comment:
why do you remove this `if`?
##########
File path: registry/registry.go
##########
@@ -30,30 +30,37 @@ import (
// Registry Extension - Registry
type Registry interface {
common.Node
- //used for service provider calling , register services to registry
- //And it is also used for service consumer calling , register services
cared about ,for dubbo's admin monitoring.
+
+ // used for service provider calling, register services to registry
Review comment:
```suggestion
// Register used for service provider calling, register services to
registry
```
##########
File path: registry/registry.go
##########
@@ -30,30 +30,37 @@ import (
// Registry Extension - Registry
type Registry interface {
common.Node
- //used for service provider calling , register services to registry
- //And it is also used for service consumer calling , register services
cared about ,for dubbo's admin monitoring.
+
+ // used for service provider calling, register services to registry
+ // And it is also used for service consumer calling, register
+ // services cared about, for dubbo's admin monitoring.
Register(url common.URL) error
// UnRegister is required to support the contract:
- // 1. If it is the persistent stored data of dynamic=false, the
registration data can not be found, then the IllegalStateException is thrown,
otherwise it is ignored.
+ // 1. If it is the persistent stored data of dynamic=false, the
+ // registration data can not be found, then the IllegalStateException
+ // is thrown, otherwise it is ignored.
// 2. Unregister according to the full url match.
- // url Registration information , is not allowed to be empty, e.g:
dubbo://10.20.153.10/org.apache.dubbo.foo.BarService?version=1.0.0&application=kylin
+ // url Registration information, is not allowed to be empty, e.g:
+ //
dubbo://10.20.153.10/org.apache.dubbo.foo.BarService?version=1.0.0&application=kylin
UnRegister(url common.URL) error
- //When creating new registry extension,pls select one of the following
modes.
- //Will remove in dubbogo version v1.1.0
- //mode1 : return Listener with Next function which can return subscribe
service event from registry
- //Deprecated!
- //subscribe(event.URL) (Listener, error)
-
- //Will replace mode1 in dubbogo version v1.1.0
- //mode2 : callback mode, subscribe with notify(notify listener).
+ // When creating new registry extension, pls select one of the
Review comment:
Add method name in front of this sentence.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
