zouyx commented on a change in pull request #722:
URL: https://github.com/apache/dubbo-go/pull/722#discussion_r481588588
##########
File path: protocol/protocolwrapper/protocol_filter_wrapper.go
##########
@@ -68,21 +68,16 @@ func (pfw *ProtocolFilterWrapper) Destroy() {
}
func buildInvokerChain(invoker protocol.Invoker, key string) protocol.Invoker {
- filtName := invoker.GetUrl().GetParam(key, "")
- if filtName == "" {
Review comment:
In this case, `filterNames` is related to `filterName` .
If some day, they dont have a relationship. I think it will cause a a hidden
problem in the future...
What do you think? @fangyincheng @AlexStocks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
