zrlw commented on a change in pull request #9015:
URL: https://github.com/apache/dubbo/pull/9015#discussion_r728799502
##########
File path:
dubbo-registry/dubbo-registry-zookeeper/src/main/java/org/apache/dubbo/registry/zookeeper/ZookeeperRegistry.java
##########
@@ -113,7 +117,7 @@ public boolean isAvailable() {
public void destroy() {
super.destroy();
try {
- zkClient.close();
+ zookeeperTransporter.close(zkClient,
getUrl().getParameter(APPLICATION_KEY, ""));
Review comment:
zookeeperTransporter will check that it is should be closed or not.
by the way, this codes could be modified after ApplicationDeployer
destroy/postDestroy is merged into 3.0 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
