zrlw commented on a change in pull request #9015:
URL: https://github.com/apache/dubbo/pull/9015#discussion_r728874856
##########
File path:
dubbo-registry/dubbo-registry-zookeeper/src/main/java/org/apache/dubbo/registry/zookeeper/ZookeeperRegistry.java
##########
@@ -113,7 +117,7 @@ public boolean isAvailable() {
public void destroy() {
super.destroy();
try {
- zkClient.close();
+ zookeeperTransporter.close(zkClient,
getUrl().getParameter(APPLICATION_KEY, ""));
Review comment:
all zookeeperRegistries are created by
ZookeeperRegistryFactory.createRegistry and put into AbstractRegistryFactory
registryManager, i think they should only be destroyed by RegistryManager
destroyAll method which will be called by DefaultApplicationDeployer
destroyRegistries().
since all zookeeperRegistries of one application are destroyed at the same
time, close zkClient at ZookeeperRegistry.destroy() is ok by now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
