[GitHub] [dubbo] zrlw commented on a change in pull request #8954: [3.0] run timeout task in separate thread to avoid the worker thread blocking

[GitBox]

zrlw commented on a change in pull request #8954:
URL: https://github.com/apache/dubbo/pull/8954#discussion_r734975022



##########
File path: 
dubbo-common/src/main/java/org/apache/dubbo/common/timer/HashedWheelTimer.java
##########
@@ -95,6 +98,10 @@
     private static final AtomicIntegerFieldUpdater<HashedWheelTimer> 
WORKER_STATE_UPDATER =
             AtomicIntegerFieldUpdater.newUpdater(HashedWheelTimer.class, 
"workerState");
 
+    private static final ExecutorService DEFAULT_TIMER_TASK_EXECUTOR =
+            
Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors(),
+            new NamedThreadFactory("HashedWheelTimerTask", true));
+

Review comment:
       branch master doesn't have GlobalResourcesRepository yet, so i just 
modified this pull, pls review again.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org