zrlw commented on a change in pull request #8954:
URL: https://github.com/apache/dubbo/pull/8954#discussion_r734977259
##########
File path:
dubbo-common/src/main/java/org/apache/dubbo/common/timer/HashedWheelTimer.java
##########
@@ -95,6 +98,10 @@
private static final AtomicIntegerFieldUpdater<HashedWheelTimer>
WORKER_STATE_UPDATER =
AtomicIntegerFieldUpdater.newUpdater(HashedWheelTimer.class,
"workerState");
+ private static final ExecutorService DEFAULT_TIMER_TASK_EXECUTOR =
+
Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors(),
+ new NamedThreadFactory("HashedWheelTimerTask", true));
+
Review comment:
it seemed that something is wrong that using GlobalResourcesRepository,
github unit test failure message: (all of them are passed by testing as
junit test) :
```
Error: Failures:
Error: DefaultFutureTest.interruptSend:158 expected: <null> but was:
<org.apache.dubbo.remoting.exchange.support.DefaultFuture@b7a74ac[Not
completed]>
Error: CloseTimerTaskTest.testClose:70 expected: <true> but was: <false>
Error: HeartBeatTaskTest.testHeartBeat:74 expected: <true> but was:
<false>
Error: ReconnectTimerTaskTest.testReconnect:73 expected: <true> but was:
<false>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
