walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1599606336
##########
dubbo-metrics/dubbo-metrics-config-center/pom.xml:
##########
@@ -27,7 +27,7 @@
<dependencies>
<dependency>
<groupId>org.apache.dubbo</groupId>
- <artifactId>dubbo-metrics-api</artifactId>
+ <artifactId>dubbo-metrics-core</artifactId>
Review Comment:
I think the current primary goal is to strip the dubbo project of its
dependence on metrics and only retain its dependence on the api, so only a very
small amount of content necessary for the dubbo project will be retained in the
api.
In fact, I renamed the 'dubbo-metrics-api' package to 'dubbo-metrics-core'
because it contains many classes that are not APIs, such as
'CombMetricsCollector'. Then a new 'dubbo-metrics-api' was added for dubbo
project integration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
