walklown commented on code in PR #14106: URL: https://github.com/apache/dubbo/pull/14106#discussion_r1599610701
########## dubbo-metrics/dubbo-metrics-config-center/pom.xml: ########## @@ -27,7 +27,7 @@ <dependencies> <dependency> <groupId>org.apache.dubbo</groupId> - <artifactId>dubbo-metrics-api</artifactId> + <artifactId>dubbo-metrics-core</artifactId> Review Comment: Or should I keep the original 'dubbo-metrics-api' (even though it contains a lot of non-API classes) and name the new 'dubbo-metrics-api' something like 'dubbo-metrics-client'? Looking forward to your suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org