aofall commented on code in PR #14194:
URL: https://github.com/apache/dubbo/pull/14194#discussion_r1604299401
##########
dubbo-plugin/dubbo-filter-validation/src/main/java/org/apache/dubbo/validation/Validation.java:
##########
@@ -25,7 +25,7 @@
/**
* Instance of Validation interface provide instance of {@link Validator}
based on the value of <b>validation</b> attribute.
*/
-@SPI("jvalidation")
Review Comment:
> Also, we can use `jvalidation-javax` and `jvalidation-jaraka` for the real
implementations.
OK, I will rename the `jvalidation` into `jvalidation-javax` and
`jvalidationNew` into `jvalidation-jakarta`
> We'd better not to change the default name
Change the default extension is to use the adapter by default.
If not change the default extension for the adapter, while the parameter of
`dubbo.provider/consumer.validation` fill in not exist extension name like
`true` or other anything, the default extension `jvalidation-javax` will try to
loaded and active.
Unless the config parameter of `dubbo.provider/consumer.validation` is
`adapter` or the newly adapter will not active if the parameter not `adapter`.
If change the default name is unexpected, also can merge the adapter logic
into jvalidation, but it could't use `@Active#onClass` on `jvalidation-javax`
extension or it will not loaded while the env not exist `javax`, and adapter
logic will also not active.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
