aofall commented on code in PR #14194:
URL: https://github.com/apache/dubbo/pull/14194#discussion_r1606303619
##########
dubbo-plugin/dubbo-filter-validation/src/main/java/org/apache/dubbo/validation/Validation.java:
##########
@@ -25,7 +25,7 @@
/**
* Instance of Validation interface provide instance of {@link Validator}
based on the value of <b>validation</b> attribute.
*/
-@SPI("jvalidation")
Review Comment:
Because of the `@Adaptive(VALIDATION_KEY)` in
`org.apache.dubbo.validation.Validation`
https://github.com/apache/dubbo/blob/9968834e621e3cff492fed91c142aa176f1d883f/dubbo-filter/dubbo-filter-validation/src/main/java/org/apache/dubbo/validation/Validation.java#L36
Here is Some description of `@Adaptive(value)`
> Decide which target extension to be injected. The name of the target
extension is decided by the parameter passed in the URL, and the parameter
names are given by this method.
>
> If the specified parameters are not found, then the default extension will
be used for dependency injection (specified in its interface's @SPI(value) ).
Fill in the parameter of `dubbo.provider/consumer.validation` will load the
extension what's the parameter named in URL. But `true` or other else charater
(exclude jvalidation and jvalidationNew) is not an exist extension. So it will
load the default extension.
And the `@SPI("value")` in `org.apache.dubbo.validation.Validation` was
already set the `jvalidation` (now renamed to `jvalidation-javax`) as default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
