AlbumenJ commented on code in PR #14409:
URL: https://github.com/apache/dubbo/pull/14409#discussion_r1671736254
##########
dubbo-common/src/main/java/org/apache/dubbo/common/url/component/URLParam.java:
##########
@@ -483,7 +483,7 @@ public String getAnyMethodParameter(String key) {
* @return A new URLParam
*/
public URLParam addParameter(String key, String value) {
- if (StringUtils.isEmpty(key) || StringUtils.isEmpty(value)) {
+ if (StringUtils.isEmpty(key)) {
Review Comment:
Why change this? This may cause some usage mistakes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
