qingkaiyan commented on code in PR #14409:
URL: https://github.com/apache/dubbo/pull/14409#discussion_r1673414888
##########
dubbo-common/src/main/java/org/apache/dubbo/common/url/component/URLParam.java:
##########
@@ -483,7 +483,7 @@ public String getAnyMethodParameter(String key) {
* @return A new URLParam
*/
public URLParam addParameter(String key, String value) {
- if (StringUtils.isEmpty(key) || StringUtils.isEmpty(value)) {
+ if (StringUtils.isEmpty(key)) {
Review Comment:
When a consumer with a * version invoke a null version provider
Building a remote URL based on the consumer's URL will be contiains * version
It's not a good result and will blocked by
PermittedSerializationKeeper.checkSerializationPermitted
This issue may only arise when the * symbol is used and The impact of the
change will be widespread
But null valus has meanings seems makes scene and 10+ application running
well when I made these changes
It's true that no one dares to say these is no other problem
I've been experimenting for over a month and haven't failed yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
