keith-turner commented on a change in pull request #883: Fixes #842 Support
multiple ways for running Fluo applications
URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r130753749
##########
File path:
modules/core/src/main/java/org/apache/fluo/core/client/FluoAdminImpl.java
##########
@@ -128,19 +140,38 @@ public void initialize(InitializationOptions opts)
throws AlreadyInitializedExce
try {
initialize(conn);
- updateSharedConfig();
- if (!config.getAccumuloClasspath().trim().isEmpty()) {
- // TODO add fluo version to context name to make it unique
- String contextName = "fluo";
+ String accumuloJars;
+ if (!config.getAccumuloJars().trim().isEmpty()) {
+ accumuloJars = config.getAccumuloJars().trim();
+ } else {
+ accumuloJars = getJarsFromClasspath();
+ }
+
+ String accumuloClasspath;
+ if (!accumuloJars.isEmpty()) {
+ accumuloClasspath = copyJarsToHdfs(accumuloJars, "lib/accumulo");
Review comment:
This is a nice change, putting the accumulo jars in a per app dfs dir.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
