keith-turner commented on a change in pull request #883: Fixes #842 Support
multiple ways for running Fluo applications
URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r130762722
##########
File path:
modules/api/src/main/java/org/apache/fluo/api/config/FluoConfiguration.java
##########
@@ -47,59 +48,140 @@
// Client properties
private static final String CLIENT_PREFIX = FLUO_PREFIX + ".client";
+ @Deprecated
public static final String CLIENT_APPLICATION_NAME_PROP = CLIENT_PREFIX +
".application.name";
+ @Deprecated
public static final String CLIENT_ACCUMULO_PASSWORD_PROP = CLIENT_PREFIX +
".accumulo.password";
+ @Deprecated
public static final String CLIENT_ACCUMULO_USER_PROP = CLIENT_PREFIX +
".accumulo.user";
+ @Deprecated
public static final String CLIENT_ACCUMULO_INSTANCE_PROP = CLIENT_PREFIX +
".accumulo.instance";
+ @Deprecated
public static final String CLIENT_ACCUMULO_ZOOKEEPERS_PROP = CLIENT_PREFIX
+ ".accumulo.zookeepers";
+ @Deprecated
public static final String CLIENT_ZOOKEEPER_TIMEOUT_PROP = CLIENT_PREFIX +
".zookeeper.timeout";
+ @Deprecated
public static final String CLIENT_ZOOKEEPER_CONNECT_PROP = CLIENT_PREFIX +
".zookeeper.connect";
+ @Deprecated
public static final String CLIENT_RETRY_TIMEOUT_MS_PROP = CLIENT_PREFIX +
".retry.timeout.ms";
+ @Deprecated
public static final int CLIENT_ZOOKEEPER_TIMEOUT_DEFAULT = 30000;
+ @Deprecated
public static final String CLIENT_ACCUMULO_ZOOKEEPERS_DEFAULT = "localhost";
+ @Deprecated
public static final String CLIENT_ZOOKEEPER_CONNECT_DEFAULT =
"localhost/fluo";
+ @Deprecated
public static final int CLIENT_RETRY_TIMEOUT_MS_DEFAULT = -1;
- // Administration
+ // Connection properties
+ public static final String CONNECTION_PREFIX = FLUO_PREFIX + ".connection";
Review comment:
Can this be private? If its public it should have a since tag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
