keith-turner commented on a change in pull request #902: fixes #894 merge
SimpleConfiguration Objects
URL: https://github.com/apache/fluo/pull/902#discussion_r131937967
##########
File path:
modules/api/src/main/java/org/apache/fluo/api/config/SimpleConfiguration.java
##########
@@ -250,6 +277,22 @@ public SimpleConfiguration subset(String prefix) {
return new SimpleConfiguration(internalConfig.subset(prefix));
}
+ /**
+ * @param SimpleConfigs SimpleConfiguration's to be merged
+ * @return SimpleConfiguration
+ *
+ * @since 1.2.0
+ */
+ public static SimpleConfiguration merge(SimpleConfiguration...
simpleConfigs) {
+ SimpleConfiguration mrg = new SimpleConfiguration();
+ for (SimpleConfiguration sc : simpleConfigs) {
+ for (Map.Entry<String, String> entry : sc.toMap().entrySet()) {
+ mrg.addProperty(entry.getKey(), entry.getValue());
Review comment:
> Instead of merge, maybe something like `defaultsTo(SimpleConfiguration)`,
or `orElse(SimpleConfiguration)`, or something like that?
@ctubbsii `orElse(SimpleConfiguration)` sounds interesting, however it
seems like a Fluent API which implies it would hang off of something. What
where you thinking it would hang off of?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
