keith-turner commented on a change in pull request #902: fixes #894 merge
SimpleConfiguration Objects
URL: https://github.com/apache/fluo/pull/902#discussion_r132312049
##########
File path:
modules/api/src/test/java/org/apache/fluo/api/config/SimpleConfigurationTest.java
##########
@@ -64,12 +64,20 @@ public void testMerge() {
diff.setProperty("set1", "value13");
diff.setProperty("set3", "value14");
+ SimpleConfiguration noChange = new SimpleConfiguration(sc3);
+ // check to make sure this is not being changed.
+ sc3.orElse(sc1).orElse(sc2);
Review comment:
need to keep the return val like
```java
sc4 = sc3.orElse(sc1).orElse(sc2);
sc3.set(...)
//ensure sc4 did not change.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
