moleske commented on a change in pull request #645:
URL: https://github.com/apache/geode-native/pull/645#discussion_r481420359
##########
File path: cppcache/integration-test/fw_dunit.cpp
##########
@@ -71,10 +71,10 @@ using
apache::geode::client::testframework::BBNamingContextServer;
#define __DUNIT_NO_MAIN__
#include "fw_dunit.hpp"
-ACE_TCHAR *g_programName = nullptr;
-uint32_t g_coordinatorPid = 0;
+static ACE_TCHAR *g_programName = nullptr;
Review comment:
I think the worst part is since I was letting the compiler tell me what
was wrong rather than proactively look for places, I build only a partial
percent at a time when it was building the integration-test. Thanks for the
reminder on places that should be able to use `const`! Putting a link to the
[`const` naming style
guide](https://google.github.io/styleguide/cppguide#Constant_Names) so I don't
forget
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
