moleske commented on a change in pull request #645:
URL: https://github.com/apache/geode-native/pull/645#discussion_r488063324
##########
File path: cppcache/benchmark/GeodeLoggingBM.cpp
##########
@@ -35,9 +35,9 @@ using apache::geode::client::internal::geode_hash;
const int STRING_ARRAY_LENGTH = 3;
-int g_iteration = 0;
+static int g_iteration = 0;
Review comment:
I'll have to look closer at the benchmark code (we have no instructions
in the CONTRIBUTING.md file about running benchmarks which seems bad...)
For the old style integration tests, I don't think I'd worry about the
paradigm, since that code is not really getting updated, more just ported to
the new style tests. In the actual production code, I don't think we want to
use an anonymous namespace
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
