jinmeiliao commented on a change in pull request #7063:
URL: https://github.com/apache/geode/pull/7063#discussion_r743344403
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientUserAuths.java
##########
@@ -90,28 +120,29 @@ public UserAuthAttributes getUserAuthAttributes(final Long
userId) {
}
@VisibleForTesting
- protected Collection<Subject> getSubjects() {
- return Collections.unmodifiableCollection(uniqueIdVsSubject.values());
- }
-
- public Subject getSubject(final Long userId) {
- return uniqueIdVsSubject.get(userId);
- }
-
- public void removeSubject(final Long userId) {
- logger.debug("Subject of {} removed.", userId);
- removeSubject(uniqueIdVsSubject.remove(userId));
+ @TestOnly
Review comment:
`@VisibleForTesting` tag was pre-existing, I added the `@TestOnly`
because I found out it's only used for test, so `TestOnly` should be more
appropriate. I removed the `VisibleForTesting` tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
