agingade commented on a change in pull request #7063:
URL: https://github.com/apache/geode/pull/7063#discussion_r745115191
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientUserAuths.java
##########
@@ -199,9 +231,12 @@ public void cleanup(boolean fromCacheClientProxy) {
}
}
- // Logout the subjects
- for (final Long subjectId : uniqueIdVsSubject.keySet()) {
- removeSubject(subjectId);
+ // for integrated security, doesn't matter if this is called from proxy
+ // or from the connection, we are closing the client connection
+ synchronized (this) {
Review comment:
As Jianxia pointed out earlier, use of synchronization can be avoided by
using Concurrent Data structures (CopyOnWriteArrayList); any reason why we can
not use them.
Also, if using synchronized, can the synchronization be done with/on the
"uniqueIdVsSubjects" instead on "this".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
