mhansonp commented on a change in pull request #7258:
URL: https://github.com/apache/geode/pull/7258#discussion_r783526855



##########
File path: 
geode-core/src/main/java/org/apache/geode/cache/client/internal/QueueManagerImpl.java
##########
@@ -926,6 +930,9 @@ private void recoverPrimary(Set<ServerLocation> 
excludedServers) {
           excludedServers.add(newPrimary.getServer());
           newPrimary = null;
         }
+
+        markAsQueueAsReadyForEvents(newPrimary);

Review comment:
       So I talked with Jinmei and I am satisfied that I have the correct 
ordering based on her understanding and mine. As far as a test goes, there is a 
test that is already in place, but it only fails periodically on my machine and 
not in the cloud. I will update that test with a couple of very minor changes, 
but I think that it (the test) is pretty much ready to go. There are more tests 
to run though beyond the one that reveals this issue.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to