jinmeiliao commented on a change in pull request #7258:
URL: https://github.com/apache/geode/pull/7258#discussion_r791075268
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/client/internal/QueueManagerImpl.java
##########
@@ -802,10 +803,13 @@ private QueueConnectionImpl
createNewPrimary(Set<ServerLocation> excludedServers
excludedServers.addAll(servers);
}
+ return primary;
Review comment:
My only concern is that after this change, `createNewPrimary()` method
doesn't send `readyForEvent` to the server anymore. This method has two usages:
`recoveryPrimary` and `initializeConnections`, `readyForEvent` will be sent by
the first usage. As long as we know for sure it has no impact on the 2nd usage.
Then this fix should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
