jinmeiliao commented on a change in pull request #7357:
URL: https://github.com/apache/geode/pull/7357#discussion_r805081603
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
##########
@@ -812,6 +795,28 @@ else if (clientUserAuths != null) {
return keepProxy;
}
+ // this needs to synchronized to avoid NPE between null check and operations
+ private synchronized void cleanClientAuths() {
Review comment:
synchronized on the clientUserauthsLock instead as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]