dschneider-pivotal commented on a change in pull request #7357:
URL: https://github.com/apache/geode/pull/7357#discussion_r806077340
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
##########
@@ -1231,11 +1233,16 @@ long putSubject(Subject subject, long existingUniqueId)
{
return uniqueId;
}
- @VisibleForTesting
+ @TestOnly
protected ClientUserAuths getClientUserAuths() {
return clientUserAuths;
}
+ @TestOnly
+ protected void setClientUserAuths(ClientUserAuths clientUserAuths) {
+ this.clientUserAuths = clientUserAuths;
Review comment:
I know this is test only, but do you see any harm in also having this
synchronize on clientUserAuthsLock? That way if someone in the future uses it
in the product, or a concurrent test is written, we will not have concurrency
issues introduced. With your other changes it seems important to all places
that set the clientUserAuths field synchronize on clientUserAuthsLock
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
