DonalEvans commented on code in PR #7569:
URL: https://github.com/apache/geode/pull/7569#discussion_r846211452
##########
geode-core/src/main/java/org/apache/geode/internal/cache/versions/DiskVersionTag.java:
##########
@@ -44,7 +44,7 @@ public void setMemberID(DiskStoreID memberID) {
@Override
public void replaceNullIDs(VersionSource memberID) {
if (getMemberID() == null) {
- throw new AssertionError("Member id should not be null for persistent
version tags");
+ throw new IllegalStateException("Member id should not be null for
persistent version tags");
Review Comment:
I'm happy to make whatever changes are requested, but I would like the
changes to be something that everyone has agreed on as the best course of
action. If @pivotal-jbarrett and @kirklund could settle on what the correct
approach is, I will implement that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
